Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[renovate]: ignore engines.yarn #18980

Closed
pieh opened this issue Oct 24, 2019 · 6 comments · Fixed by #18981
Closed

[renovate]: ignore engines.yarn #18980

pieh opened this issue Oct 24, 2019 · 6 comments · Fixed by #18981
Assignees
Labels
help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@pieh
Copy link
Contributor

pieh commented Oct 24, 2019

Summary

Our current renovate config, result in engines.yarn bumps, which is something we don't want. Not only it would unnecessarily force users to be on latest yarn version, it also make it problematic to run checks on CI (as images used on CircleCI doesn't seem to come with latest yarn version):

Screenshot 2019-10-24 at 13 44 01

Screenshot 2019-10-24 at 14 10 01

Screenshots from #18875

Task

Update https://github.com/gatsbyjs/gatsby/blob/master/renovate.json configuration, so it doesn't try to update engines

@pieh pieh added help wanted Issue with a clear description that the community can help with. Hacktoberfest type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change labels Oct 24, 2019
@wpanas
Copy link
Contributor

wpanas commented Oct 24, 2019

I can take it :)

@pieh
Copy link
Contributor Author

pieh commented Oct 24, 2019

Nice, go for it @wpanas!

@wpanas
Copy link
Contributor

wpanas commented Oct 24, 2019

Can you give me a hint how to test if my changes worked?

@pieh
Copy link
Contributor Author

pieh commented Oct 24, 2019

Right now I don't have nice solution, but I think creating test repository that would have engines.yarn set in package.json and trying out renovate configuration changes there might be the way to go?

Alternatively if you would find good resource for this, we could just live test changes here directly (as right now we are blocked and can't merge renovate PRs anyway), and we could try force renovate PR refresh

@wpanas
Copy link
Contributor

wpanas commented Oct 24, 2019

I used https://docs.renovatebot.com/configuration-options/#ignoredeps to fix it. Either it works or not, but I'm certain that it won't not break anything. It uses exact match, so only yarn is going to be excluded. Other dependencies are going to stay safe and sound.

@sidharthachatterjee
Copy link
Contributor

@wpanas Thanks! Left a comment on your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants