Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-offline): Update incorrect casing for runtimeCachin… #19817

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

samlogan
Copy link
Contributor

@samlogan samlogan commented Nov 27, 2019

…g handlers

Description

Current configuration object with camel case handlers returns:

ValidationError: child "runtimeCaching" fails because ["runtimeCaching" at position 0 fails because [child "handler" fails because ["handler" must be a Function, "handler" must be one of [cacheFirst, cacheOnly, networkFirst, networkOnly, staleWhileRevalidate]]]]

…g handlers

Current configuration object with camel case handlers returns:

```
ValidationError: child "runtimeCaching" fails because ["runtimeCaching" at position 0 fails because [child "handler" fails because ["handler" must be a Function, "handler" must be one of [cacheFirst, cacheOnly, networkFirst, networkOnly, staleWhileRevalidate]]]]
```
@samlogan samlogan requested a review from a team as a code owner November 27, 2019 04:35
@freiksenet
Copy link
Contributor

Thanks!

@freiksenet freiksenet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 27, 2019
@gatsbybot gatsbybot merged commit b44aca0 into gatsbyjs:master Nov 27, 2019
@gatsbot
Copy link

gatsbot bot commented Nov 27, 2019

Holy buckets, @samlogan — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants