Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning when some GraphQL query gets stuck #21825

Closed
vladar opened this issue Feb 28, 2020 · 4 comments
Closed

Display a warning when some GraphQL query gets stuck #21825

vladar opened this issue Feb 28, 2020 · 4 comments
Labels
topic: GraphQL Related to Gatsby's GraphQL layer

Comments

@vladar
Copy link
Contributor

vladar commented Feb 28, 2020

Summary

There are situations when GraphQL queries run too long (due to cycles in data or very deep query structure). For example #21758

We should account for this and display a warning after 30 seconds of query running (the timeout value may change). This warning will mention the Component with a bad query.

We should also consider adding complexity scoring in the future which could warn users about possible problems during the query validation step.

@chuyenlee
Copy link

That's great.

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 20, 2020
@github-actions
Copy link

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@vladar vladar added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Mar 30, 2020
@wardpeet wardpeet reopened this Mar 31, 2020
@danabrit danabrit added the topic: GraphQL Related to Gatsby's GraphQL layer label May 29, 2020
@vladar
Copy link
Contributor Author

vladar commented Jul 24, 2020

This is actually done via #23261

@vladar vladar closed this as completed Jul 24, 2020
@LekoArts LekoArts removed the not stale label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

No branches or pull requests

5 participants