Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: starters listing not respecting the sort parameter #23297

Closed
praveenweb opened this issue Apr 20, 2020 · 2 comments
Closed

docs: starters listing not respecting the sort parameter #23297

praveenweb opened this issue Apr 20, 2020 · 2 comments
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@praveenweb
Copy link
Contributor

praveenweb commented Apr 20, 2020

Description

According to this code www/src/pages/index.js and this code www/src/views/starter-library/starter-list.js and from my previous browsing history, the starters list is sorted by stars on initial load. Right now the starters list doesn't seem to respect that sort parameter.

Possibly bug introduced post this PR getting merged - #21792. Using a commit before this PR merge seems to work as expected.

Steps to reproduce

Visit https://www.gatsbyjs.org/starters?v=2 and look at the results and default sort parameter used.

Expected result

The expected result is that starters should be sorted based on stars.

Actual result

Actual result is that starters are sorted based on recent additions to starters.yml.

@praveenweb praveenweb added the type: bug An issue or pull request relating to a bug in Gatsby label Apr 20, 2020
@gatsbot gatsbot bot added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Apr 20, 2020
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 11, 2020
@praveenweb praveenweb added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels May 11, 2020
@AishaBlake AishaBlake removed the type: documentation An issue or pull request for improving or updating Gatsby's documentation label May 27, 2020
@praveenweb
Copy link
Contributor Author

Fixed in #24668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

4 participants