Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readme): gatsby-remark-images -> put code in code fences #25854

Merged
merged 3 commits into from
Jul 31, 2020
Merged

fix(readme): gatsby-remark-images -> put code in code fences #25854

merged 3 commits into from
Jul 31, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Jul 19, 2020

Description

changes:

  • put code in code fences

Related Issues

@muescha muescha requested a review from a team as a code owner July 19, 2020 13:15
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 19, 2020
@muescha muescha marked this pull request as draft July 19, 2020 15:58
@sidharthachatterjee sidharthachatterjee added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 20, 2020
@gatsby-cloud-staging
Copy link

Gatsby Cloud Build Report

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 51y

@muescha muescha marked this pull request as ready for review July 20, 2020 15:50
@muescha
Copy link
Contributor Author

muescha commented Jul 20, 2020

Build time: 51y

long time :)

AishaBlake
AishaBlake approved these changes Jul 31, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch! Thanks as always, @muescha!

@AishaBlake AishaBlake merged commit 96fdb6b into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the muescha-fix-readme-gatsby-remark-images-code-fences branch July 31, 2020 20:24
@AishaBlake AishaBlake added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: needs docs review Pull request related to documentation waiting for review labels Jul 31, 2020
resource11 pushed a commit to katkage/gatsby that referenced this pull request Aug 1, 2020
@muescha @resource11
fix(readme): gatsby-remark-images -> put code in code fences (gatsbyj…
27451b3 
…s#25854)

* put code in code fences

* more code fences

* lint
blainekasten pushed a commit that referenced this pull request Aug 6, 2020
@muescha @blainekasten
fix(readme): gatsby-remark-images -> put code in code fences (#25854)
49de8b2 
* put code in code fences

* more code fences

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AishaBlake AishaBlake AishaBlake approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muescha @AishaBlake @sidharthachatterjee