Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console errors should have a background color #2645

Closed
benjaminhoffman opened this issue Oct 26, 2017 · 6 comments
Closed

Console errors should have a background color #2645

benjaminhoffman opened this issue Oct 26, 2017 · 6 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby

Comments

@benjaminhoffman
Copy link
Contributor

The error window is not defined renders white text. If this error is read in a browser or terminal with a white brackground, the text is essentially hidden. See attached. May want to include a darker bg color so this text stands out.
screen shot 2017-10-26 at 12 11 56 pm
@benjaminhoffman benjaminhoffman changed the title window is not defined error needs a background color Console errors should have a background color Nov 2, 2017
@benjaminhoffman
Copy link
Contributor Author

another example.

screen shot 2017-11-02 at 1 14 14 pm

@dustinhorton dustinhorton mentioned this issue Nov 16, 2017
Closed
@benjaminhoffman benjaminhoffman added the good first issue Issue that doesn't require previous experience with Gatsby label Dec 2, 2017
@benjaminhoffman benjaminhoffman mentioned this issue Dec 5, 2017
Closed
@r1b
Copy link
Contributor

r1b commented Dec 5, 2017

Perhaps the entire background should be red like the background of the error prototype. I would be happy to fix this.

@imjared
Copy link

imjared commented Jan 16, 2018

@r1b did you take a pass at this?

@r1b
Copy link
Contributor

r1b commented Jan 17, 2018

@imjared no i'm sorry :( - life has gotten in the way

@fk fk added the DX label Jan 19, 2018
This was referenced Jan 27, 2018
Closed
Closed
Merged
@alexparish
Copy link
Contributor

Mind if I have a look at this?

@alexparish alexparish mentioned this issue Mar 19, 2018
Merged
@ComputerCarl
Copy link

I have grey copy on a red background which is difficult to read. Could you tell if and where I could change this?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue that doesn't require previous experience with Gatsby
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fk @alexparish @imjared @r1b @benjaminhoffman @ComputerCarl