fix(gatsby-plugin-image): Fix StaticImage props interface and add propTypes #28372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
commented
Nov 30, 2020
| @@ -1,7 +1,9 @@ | |||
| /* global SERVER */ | |||
| // eslint-disable-next-line @typescript-eslint/triple-slash-reference | |||
| /// <reference path="../global.d.ts" /> | |||
There was a problem hiding this comment.
I don't know why this has regressed, but this seems to be the onyl way I can get it to include the globals in the compilation
laurieontech
approved these changes
Nov 30, 2020
pieh
pushed a commit
that referenced
this pull request
Dec 1, 2020
…pTypes (#28372) (#28402) * Add proptypes and better props defs * Fix compilation error (cherry picked from commit 93a1447) Co-authored-by: Matt Kane <[email protected]>
LekoArts
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the interface for StaticImage props, and adds
propTypesvalidation. Previously doing something like passing a string for "width" would lead to the image not resolving, rather than giving a helpful error. This now also enforces proptypes based on the layout, e.g. requiring width and forbidding maxWidth in fixed layout images. It also stops passing through all props to the DOM element, as that was causing react errors