fix(gatsby-plugin-image): pass down missing sizes attribute to <sources> (fixes #29093) #29092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Grsmto
changed the title
|
Thank you! Good spot. |
ascorbic
approved these changes
Jan 20, 2021
ascorbic
added
topic: media
gatsbybot
pushed a commit
that referenced
this pull request
Jan 20, 2021
…es> (#29092) (#29108) (cherry picked from commit 2e42197) Co-authored-by: Adrien Denat <[email protected]>
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
gatsby-plugin-imagecurrently does not pass down thesizesprop to the<source>element, which cause the highest image to always be chosen by the browser. Only passing it to<img>is not sufficient.By passing it down, the browser can now properly choose the right image based on the
sizesproperty.Also, the previous
gatsby-imagewas working this way, so this is simply a bug fix and nothing more.Related Issues
#29093