-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-image): Add resolver helper and improve custom hook #29342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 5, 2021
ascorbic
added
topic: media
Related to gatsby-plugin-image, or general image/media processing topics
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 5, 2021
ascorbic
force-pushed
the
feat/image-url-builder
branch
from
February 9, 2021 15:45
c333e50
to
79e38aa
Compare
ascorbic
changed the title
feat(gatsby-plugin-image): Add image url builder helper hook
feat(gatsby-plugin-image): Add resolver helper improve custom hook hook
Feb 9, 2021
ascorbic
changed the title
feat(gatsby-plugin-image): Add resolver helper improve custom hook hook
feat(gatsby-plugin-image): Add resolver helper and improve custom hook hook
Feb 9, 2021
ascorbic
changed the title
feat(gatsby-plugin-image): Add resolver helper and improve custom hook hook
feat(gatsby-plugin-image): Add resolver helper and improve custom hook
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Left one recommendation. The text is lifted from stuff we've already reviewed, so assuming that's boilerplate.
Co-authored-by: LB <[email protected]>
laurieontech
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
getGatsbyImageResolver
helper, which is designed to be used withcreateResolvers
. It creates the full field config, with the required args defined. You pass it the actual resolver function. This is easier to use than the current helper, which is based on the old sharp and Contentful resolvers which use the deprecatedsetFieldsOnGraphQLNodeType
API. Usage for the new helper is:This PR also simplifies the
useGatsbyImage
hook, which is a helper to allow image hosts with URL APIs to create custom hooks and components supporting gatsby-plugin-image. The main requirement is for a URL builder function which can generate an image URL when given a base URL and dimensions.The following is an example using the imgix rendering API. It defines a
useImgix
hook that returns an object which can be passed to<GatsbyImage>
:This can then be used like this:
It can also be used to create custom image components:
...which can be used like this: