feat: enable better cssOptions override for modules #30112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
reviewed
Mar 9, 2021
Co-authored-by: Lennart <[email protected]>
Co-authored-by: Lennart <[email protected]>
LekoArts
reviewed
Mar 11, 2021
justinwaite
reviewed
Mar 14, 2021
packages/gatsby-plugin-postcss/src/__tests__/gatsby-node.test.js
Outdated
Show resolved
Hide resolved
packages/gatsby-plugin-postcss/src/__tests__/gatsby-node.test.js
Outdated
Show resolved
Hide resolved
packages/gatsby-plugin-postcss/src/__tests__/gatsby-node.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Justin Waite <[email protected]>
Co-authored-by: Justin Waite <[email protected]>
Co-authored-by: Justin Waite <[email protected]>
Co-authored-by: Justin Waite <[email protected]>
|
This is will be extremely helpful for migration from v2 to v3, since moving a big project to the new CSS modules exports is complicated and does not have any advantages if the project is well written. Thank you for the fix, you saved me a lot of time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable overriding of esModule props to support old commonjs Syntax.
Documentation
PR #30267 needs to be merged when released
Related Issues
Fixes #29955
Fixes #30040
[ch27340]