fix(gatsby-plugin-image): Use bare GATSBY___IMAGE global #30713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the feedback! I'll admit that my fix was rather crude, and I'm glad that this PR solves the underlying issue! Thanks again! |
LekoArts
reviewed
Apr 7, 2021
packages/gatsby-plugin-image/src/components/__tests__/gatsby-image.browser.tsx
Show resolved
Hide resolved
LekoArts
added
the
topic: media
LekoArts
pushed a commit
that referenced
this pull request
Apr 7, 2021
* fix(gatsby-plugin-image): Use bare GATSBY___IMAGE global * Fix check * Fix test * Use helper * Remove unused type (cherry picked from commit a5869e3)
LekoArts
pushed a commit
that referenced
this pull request
Apr 7, 2021
…0734) * fix(gatsby-plugin-image): Use bare GATSBY___IMAGE global * Fix check * Fix test * Use helper * Remove unused type (cherry picked from commit a5869e3) Co-authored-by: Matt Kane <[email protected]>
|
Published in |
This was referenced Apr 13, 2021
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image plugin currently defines
global.GATSBY___IMAGEto detect when the plugin is installed, which causes problems with thrid-party plugins. This changes it to just create a bare globalGATSBY___IMAGE, and updates types to match.Thanks @kelvindecosta for his PR, but there were some issues in the approach there so I have opened this instead.
Fixes #30093, fixes #30094, fixes #30456, fixes #30609