fix(gatsby,gatsby-plugin-image): fix createRoot on React 18 #32378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: core
wardpeet
commented
Jul 15, 2021
| @@ -194,7 +194,7 @@ apiRunnerAsync(`onClientEntry`).then(() => { | |||
| document.body.append(indicatorMountElement) | |||
|
|
|||
| if (renderer === ReactDOM.hydrateRoot) { | |||
| renderer(indicatorMountElement).render( | |||
| ReactDOM.createRoot(indicatorMountElement).render( | |||
There was a problem hiding this comment.
There is not html to hydrate so we d a regular root
LekoArts
reviewed
Jul 16, 2021
wardpeet
commented
Jul 16, 2021
LekoArts
approved these changes
Jul 16, 2021
LekoArts
pushed a commit
that referenced
this pull request
Jul 19, 2021
(cherry picked from commit 79b7b04)
LekoArts
pushed a commit
that referenced
this pull request
Jul 19, 2021
…32420) Co-authored-by: Ward Peeters <[email protected]>
This was referenced Jul 21, 2021
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to
createRootfor gatsby-plugin-image and indicatorDocumentation
Related Issues
#31943