Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs site does not have distinct titles for all pages #3469

Closed
markerikson opened this issue Jan 11, 2018 · 2 comments · May be fixed by tejzpr/gatsby#61
Closed

Docs site does not have distinct titles for all pages #3469

markerikson opened this issue Jan 11, 2018 · 2 comments · May be fixed by tejzpr/gatsby#61
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@markerikson
Copy link

markerikson commented Jan 11, 2018 •
edited
Loading

Description

Several portions of the Gatsby docs site have the same basic title: "GatsbyJS". It appears that other portions of the docs do have a distinct title, such as "Building with Components | GatsbyJS", but the "Getting Started" page and the Gatsby blog page only say "GatsbyJS".

Those happened to be the first two links I opened up off the Gatsby home page, so my immediate assumption was that all of the docs pages only said "GatsbyJS". It was only after I clicked around further that I realized most of the docs pages do have distinct titles.

It would be good if every page had a distinct title. Keeping the home page as just "GatsbyJS" would be reasonable, but the others should be "Getting Started | GatsbyJS" and "Blog | GatsbyJS", or something similar.

Environment

Gatsby docs site
@KyleAMathews
Copy link
Contributor

👍 agreed!

Anyone (Mark? :-)) want to create a PR? We'd just need to a React Helmet call to set the title on those pages.

@fk fk added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 13, 2018
@benforshey benforshey mentioned this issue Jan 16, 2018
Merged
@KyleAMathews
Copy link
Contributor

@benforshey fixed this in #3550 🎉

@tejzpr tejzpr mentioned this issue Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 29 vulnerabilities tejzpr/gatsby
3 participants
@fk @KyleAMathews @markerikson