fix(gatsby-plugin-image): Add outputPixelDensities to SHARP_ATTRIBUTES
#36203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`outputPixelDensities` in `StaticImage` was ignored due to its absence in `SHARP_ATTRIBUTES`.
gatsbot
bot
added
the
status: triage needed
|
Thanks @B11, can you also add a test for it in https://github.com/gatsbyjs/gatsby/tree/master/e2e-tests/visual-regression |
wardpeet
added
topic: media
|
It just looks like a simple omission. And it usually doesn‘t cause a noticeable visual difference. |
|
Since this is a well tested React component we don't want to let this coverage slip, so we'd very much appreciate if you can add a test case to the mentioned suite. Let us know if you need any assistance, thanks! |
LekoArts
added
the
status: awaiting author response
|
I'm new to NodeJS and I'm not familiar with Gatsby yet. I encountered this issue, and I found it was just a simple omission in the source code, based on years of experience in other languages. |
LekoArts
removed
the
status: awaiting author response
LekoArts
changed the title
outputPixelDensities to SHARP_ATTRIBUTES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outputPixelDensitiesinStaticImagewas ignored due to its absence inSHARP_ATTRIBUTES.Related Issues
Fixes #32552
Fixes #33883