Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a dependency on spdlog_vendor. #6

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Add in a dependency on spdlog_vendor. #6

merged 2 commits into from
Sep 10, 2024

Conversation

clalancette
Copy link
Contributor

That way when building on e.g. Windows, the paths to spdlog will be setup properly before trying to build this vendor package.

@clalancette
Add in a dependency on spdlog_vendor.
a5d3f83 
That way when building on e.g. Windows, the paths to
spdlog will be setup properly before trying to build this
vendor package.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

@azeey FYI

@clalancette
Copy link
Contributor Author

Pulls: #6
Gist: https://gist.githubusercontent.com/clalancette/11847a66a3f19f2c5d5e06095eb9f2a5/raw/2869a3727fde4ad25d8bb20f1713dd9e5d58af02/ros2.repos
BUILD args: --packages-above-and-dependencies gz_utils_vendor
TEST args: --packages-above gz_utils_vendor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14533

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette mentioned this pull request Sep 6, 2024
Closed
@clalancette
Also remove the spdlog dependency.
995cf26 
That's because we will just depend on the vendor package to
provide that dependency for us as necessary.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

Pulls: #6
Gist: https://gist.githubusercontent.com/clalancette/b8a2f4e72261d8b92ce938a70e5d4557/raw/2869a3727fde4ad25d8bb20f1713dd9e5d58af02/ros2.repos
BUILD args: --packages-above-and-dependencies gz_utils_vendor
TEST args: --packages-above gz_utils_vendor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14536

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@azeey azeey mentioned this pull request Sep 6, 2024
Merged
azeey
azeey approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! I've updated the script that generates these and I believe it matches this PR: gazebo-tooling/gz_vendor#9

@azeey azeey mentioned this pull request Sep 6, 2024
Closed
8 tasks
@clalancette
Copy link
Contributor Author

With CI green and an approval, I'm going to go ahead and merge this one.

@clalancette
Copy link
Contributor Author

Oh! Actually, I have no permissions here, @azeey can you go ahead and do it? Thanks.

@azeey azeey merged commit cb0f0b0 into gazebo-release:rolling Sep 10, 2024
1 check failed
@clalancette clalancette deleted the clalancette/add-spdlog-vendor-dep branch September 10, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @azeey