Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model loader checking for hidden directories #489

Open
osrf-migration opened this issue Feb 8, 2013 · 9 comments
Open

model loader checking for hidden directories #489

osrf-migration opened this issue Feb 8, 2013 · 9 comments
Labels
all bug Something isn't working minor

Comments

@osrf-migration
Copy link

Original report (archived issue) by Thomas Koletschka (Bitbucket: thomasko).


The newer Gazebo versions seem to also include hidden, unrelated directories in its GAZEBO_MODEL_PATH which then leads to error messages like these (non-fatal but still wrong and confusing): Error [InsertModelWidget.cc:252] model.config file is missing in directory["/home/drc/repo/trunk/worlds/drc_models/.svn"] (drc_models is in the GAZEBO_MODEL_PATH)

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Thanks. I need to update the message to report a better error when an incorrect directory is in the model database path.

You shouldn't point GAZEBO_MODEL_PATH to a directory that is version controlled. This can lead to bad side effects.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed priority from "major" to "minor"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "new" to "on hold"

Until 2.0

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


  • changed state from "on hold" to "open"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set version to "all"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "open" to "new"

@osrf-migration osrf-migration added minor bug Something isn't working all labels Apr 19, 2020
@traversaro
Copy link
Collaborator

traversaro commented Feb 26, 2022

Ok, I think at this point I spend much more time explaining to new users why this is not a problem, so it may be worth trying to mitigate this.

My proposals are:

  • P1: In all cases, turn this from an error to just a warning
  • P2: Provide a mechanism to opt out in specific directories. A possible idea is to not print the warning if in the parent directory (i.e. the one added to the GAZEBO_MODEL_PATH) contains a file that starts with .gazebo_allow_directories_without_model_config

Any opinion on this? Note that we can easily implement just P1 or P2 or implement both, the proposal are quite indipendent.

@traversaro
Copy link
Collaborator

Thinking a bit more, probably P1 does not make a lot of sense. I still think that P2 is a convenient idea.

@traversaro
Copy link
Collaborator

See also KumarRobotics/mrsl_quadrotor#4 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

2 participants