🧑‍🌾 Flaky Download Model tests (FuelClient, UNIT_gz_src_TEST, UNIT_Interface_TEST)

[Crola1702]

Environment

• OS Version: Ubuntu Focal 20.04
• Source build?

Description

• Expected behavior: FuelClient, UNIT_gz_src_TEST, and UNIT_Interface_TEST should not fail
• Actual behavior: These test sometimes fail when downloading the models

Steps to reproduce

1. Run a build on https://build.osrfoundation.org/job/ignition_fuel-tools-ci-gz-fuel-tools8-focal-amd64/
2. See it fail if lucky.

Output

I see this PR made changes on gz_src_TEST.cc for model downloading tests.

Build 21:

FlueClient:

[Err] [FuelClient.cc:662] Failed to download model.
  Server: https://fuel.gazebosim.org
  Route: chapulina/models/test box/tip/test box.zip
  REST response code: 504

Build 20:

It passed (no errors dowloading any model)

Build 19:

FuelClient:

[Err] [FuelClient.cc:662] Failed to download model.
  Server: https://fuel.gazebosim.org
  Route: chapulina/models/test box/tip/test box.zip
  REST response code: 504

Build 18:

UNIT_Interface_TEST:

[Err] [FuelClient.cc:662] Failed to download model.
  Server: https://fuel.gazebosim.org
  Route: openrobotics/models/bus/1/bus.zip
  REST response code: 504

UNIT_gz_src_TEST

[Err] [FuelClient.cc:662] Failed to download model.
  Server: https://fuel.gazebosim.org
  Route: openroboticstest/models/backpack/tip/backpack.zip
  REST response code: 504
[Err] [FuelClient.cc:662] Failed to download model.
  Server: https://fuel.gazebosim.org
  Route: openroboticstest/models/teambase/tip/teambase.zip
  REST response code: 504

[nkoenig]

We need to update the Fuel server to use S3 as a download mechanism. Currently, a download can be affected by Fuel load.

[nkoenig]

#316 will help

[Crola1702]

We now have new gz_src_TEST.CollectionTest/DownloadCollectionTest test regressions in gz-fuel-tools8 focal

Reference build: https://build.osrfoundation.org/job/ignition_fuel-tools-ci-gz-fuel-tools8-focal-amd64/24/

CollectionTest/DownloadCollectionTest.AllItems log output:

/home/jenkins/workspace/ignition_fuel-tools-ci-gz-fuel-tools8-focal-amd64/ign-fuel-tools/src/gz_src_TEST.cc:398
Value of: common::isDirectory( common::joinPaths(this->testCachePath, "fuel.gazebosim.org", "openroboticstest", "models", "backpack", "2"))
  Actual: false
Expected: true

CollectionTest/DownloadCollectionTest.Models log output:

/home/jenkins/workspace/ignition_fuel-tools-ci-gz-fuel-tools8-focal-amd64/ign-fuel-tools/src/gz_src_TEST.cc:461
Value of: common::isDirectory( common::joinPaths(this->testCachePath, "fuel.gazebosim.org", "openroboticstest", "models", "backpack", "2"))
  Actual: false
Expected: true

@nkoenig do you think this could be a gz-common or fuel-tools problem?

[Crola1702]

Taking a close look at the issue, it seems the error is related to common::joinPaths.

We already have an issue for that one, so I'll link it here: #307

It might be failing because:

This test is probably failing because of #106 (reported 2 years ago).

[Crola1702]

Redirecting this issue to #340