Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to end up with a finite box with EXTENT_NULL #53

Closed
osrf-migration opened this issue Nov 8, 2016 · 3 comments
Closed

Possible to end up with a finite box with EXTENT_NULL #53

osrf-migration opened this issue Nov 8, 2016 · 3 comments
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


All boxes get initialized with EXTENT_NULL. So it's possible that one sets the box minimum and maximum directly, and the box will still not have EXTENT_FINITE.

See this gazebo pull request for an example of the issues this might cause.

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


we may need to replace &Box::Min() and &Box::Max with Box::SetMin and Box::SetMax but that's an API change..

or change default min and max values to nans or infs to we know if they've been set or not.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Related to issue #72

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • changed state from "new" to "resolved"

pull request #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant