Disable building examples by default #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Introduced by: #301
Fixes gazebosim/gz-math#539
Summary
While the new cmake-native mechanism for building examples allows it to work on Windows, it also regresses on non-colcon builds.
When colcon builds run, each package is called with
cmake && make && make install
during thecolcon build
phase, and thenmake test
is called during thecolcon test
phase. This guarantees that the package is installed somewhere before attempting to run the tests, which is what the examples need.In builds like the deb-builder, this sequence is instead
make && make test
to verify that the package has been correctly built before creating the deb.This PR makes building examples off by default, and can be enabled by adding
-DBUILD_EXAMPLES:bool=True
to the cmake args for local and CI builds.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.