You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SDF spec calls for the first link to be the canonical link if the attribute //model/@canonical_link is unspecified. However, TPE stores entities in an std::map which does not preserve order in which the entities are added.
pull request #86 attempted to workaround this by marking the first link added as the canonical link but the logic does not work when the model has multiple nested models and no top level links.
I think either option works. I'm leaning towards 2. too as that seems to be easier to implement without having to modify other functions that touch the std::map variable.
Note that currently we only support one canonical link for a model (which can consist of nested models). You'll likely have to revert this change that I did that assumes the first link added is the canonical link: https://github.com/ignitionrobotics/ign-physics/blob/ign-physics2/tpe/lib/src/Model.cc#L66, since it does not work for nested models without top level links.
The SDF spec calls for the first link to be the canonical link if the attribute
//model/@canonical_link
is unspecified. However, TPE stores entities in anstd::map
which does not preserve order in which the entities are added.pull request #86 attempted to workaround this by marking the first link added as the canonical link but the logic does not work when the model has multiple nested models and no top level links.
see this comment for more info: #86 (comment)
The text was updated successfully, but these errors were encountered: