Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test examples on CI #109

Closed
chapulina opened this issue Sep 29, 2020 · 1 comment · Fixed by #133
Closed

Test examples on CI #109

chapulina opened this issue Sep 29, 2020 · 1 comment · Fixed by #133
Labels
enhancement New feature or request tests Broken or missing tests / testing infra

Comments

@chapulina
Copy link
Contributor

The examples are not tested on CI, so it's easy to forget to update them. We should be testing them on CI like other libraries do:

I think at least some of the libraries above require the library to be installed before running these tests, which is not ideal. I believe there are ways to work around this though, by setting environment variables, or installing, but to a local directory.

@chapulina chapulina added enhancement New feature or request tests Broken or missing tests / testing infra labels Sep 29, 2020
@ahcorde ahcorde linked a pull request Nov 4, 2020 that will close this issue
@ahcorde
Copy link
Contributor

ahcorde commented Nov 4, 2020

Already merged

@ahcorde ahcorde closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants