Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object name #14

Open
osrf-migration opened this issue Dec 14, 2017 · 6 comments
Open

Object name #14

osrf-migration opened this issue Dec 14, 2017 · 6 comments
Labels
enhancement New feature or request proposal

Comments

@osrf-migration
Copy link

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


The name of objects (Object::Name) is used by the GUI, but the Name is not user friendly. For example, the name has a number in order to guarantee uniqueness.

Maybe an Object can support a "user-friendly" name as well.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Also worth pointing out that the API already supports an id per object, so the names shouldn't need to carry the random sequence of numbers.

@osrf-migration
Copy link
Author

Original comment by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).


If it already has an id, do objects in the rendering library need a name at all? Maybe the name concept only needs to exist on the GUI.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


That's a valid point, I think rendering could get rid of names.

The only things I can think of them being useful for is debugging or if eventually rendering starts communicating using ign-transport and has to handle topic names.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Names are useful for introspection, and debugging.

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


agreed that names should not need to be unique. There're currently places in ign-rendering that assume unique names, will looking changing that logic

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • Edited issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal
Projects
None yet
Development

No branches or pull requests

2 participants