Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide information about the Ogre version used at configure time #375

Closed
j-rivero opened this issue Aug 10, 2021 · 3 comments
Closed

Provide information about the Ogre version used at configure time #375

j-rivero opened this issue Aug 10, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@j-rivero
Copy link
Contributor

Desired behavior

Not all the Ogre versions are officially supported in Ignition but most of them can be used to compile the software. It would be useful to provide users with information when they are not using the supported versions.

Alternatives considered

At least a couple of approaches can be done:

  1. Enable unsupported versions using a cmake flag. Fail the build if the versions is not one of the supported ones and implement a flag to enable the configuration to pass with others.

  2. Warn users if the ogre version used is not the officially supported one but leave the configuration to finish.

Implementation suggestion

Not to break people builds out there I think that the safer approach would be to go with 2.

Additional context

See problems in #374

@chapulina
Copy link
Contributor

See #376

@Blast545
Copy link
Contributor

I think this can be closed, as #376 is merged.

@j-rivero
Copy link
Contributor Author

I think this can be closed, as #376 is merged.

Yup, gracias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants