Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make joint state publisher's topic configurable #1057

Closed
chapulina opened this issue Sep 27, 2021 · 2 comments · Fixed by #1076
Closed

Make joint state publisher's topic configurable #1057

chapulina opened this issue Sep 27, 2021 · 2 comments · Fixed by #1076
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chapulina
Copy link
Contributor

Desired behavior

The JointStatePublisher plugin always publishes on the /world/<world_name>/model/<model_name>/state topic. It would be convenient to let users change it, especially so that models can be more easily reused across worlds of different names.

Alternatives considered

N/A

Implementation suggestion

The topic should be configurable from SDF.

The same way that we accept a joint_name element here:

https://github.com/ignitionrobotics/ign-gazebo/blob/59ff8532d0699f18cf9d0e34aa1bc0afecb73671/src/systems/joint_state_publisher/JointStatePublisher.cc#L61

We could accept a topic element, like how this other plugin does it for example:

https://github.com/ignitionrobotics/ign-gazebo/blob/59ff8532d0699f18cf9d0e34aa1bc0afecb73671/src/systems/detachable_joint/DetachableJoint.cc#L99-L106

@chapulina chapulina added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2021
@jasmeet0915
Copy link
Contributor

Hi, I was looking for first time issues and have been able to resolve this one. I would like to make a PR for the same!

@chapulina
Copy link
Contributor Author

That's great, thanks @jasmeet0915 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants