Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate linear and angular min/max values in DiffDrive #1227

Open
roni-kreinin opened this issue Dec 1, 2021 · 2 comments
Open

Separate linear and angular min/max values in DiffDrive #1227

roni-kreinin opened this issue Dec 1, 2021 · 2 comments
Labels
enhancement New feature or request help wanted We accept pull requests!

Comments

@roni-kreinin
Copy link
Contributor

Desired behavior

Currently the min/max velocity, acceleration, and jerk parameters are applied to both linear and angular vel/accel/jerk. It would be useful to separate linear and angular as you often want different values for these.

Implementation suggestion

Separate the parameters into:

  • min_linear_velocity
  • max_linear_velocity
  • min_angular_velocity
  • max_angular_velocity
  • min_linear_acceleration
  • max_linear_acceleration
  • min_angular_acceleration
  • max_angular_acceleration
  • min_linear_jerk
  • max_linear_jerk
  • min_angular_jerk
  • max_angular_jerk
@roni-kreinin
Copy link
Contributor Author

Added PR. See #1229

@chapulina
Copy link
Contributor

Thanks for the PR. For completeness, we should apply the same fix to all other controllers. I'll leave this issue open until they're all addressed:

  • AckerMannSteering
  • MecanumDrive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

2 participants