Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDFGenerator to use SDF DOM #1312

Open
nkoenig opened this issue Jan 25, 2022 · 0 comments
Open

Update the SDFGenerator to use SDF DOM #1312

nkoenig opened this issue Jan 25, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted We accept pull requests!

Comments

@nkoenig
Copy link
Contributor

nkoenig commented Jan 25, 2022

Desired behavior

The SDFGenerator code manually creates SDF elements instead of using the SDF DOM. The problem is that this code can be difficult to maintain, and it's missing some features.

Implementation suggestion

Update the SdfGenerator functions to use the SDF DOM objects. This should make the output consistent with other users of libsdformat, and can take advantage of SDF improvements as they are released without requiring additional updates to the SDFGenerator code.

@nkoenig nkoenig added the enhancement New feature or request label Jan 25, 2022
@nkoenig nkoenig self-assigned this Jan 25, 2022
@chapulina chapulina added the help wanted We accept pull requests! label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

2 participants