Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing coefficients in LiftDrag Plugin #2188

Closed
fredmarkus opened this issue Oct 3, 2023 · 0 comments · Fixed by #2189
Closed

Missing coefficients in LiftDrag Plugin #2188

fredmarkus opened this issue Oct 3, 2023 · 0 comments · Fixed by #2189

Comments

@fredmarkus
Copy link
Contributor

I was going through the code for the liftdrag plugin and noticed that the cm coefficient was set to 0. Above it is a comment marking it as todo, saying "it needs testing". I was wondering what was not working well that it had to be set to 0? The issue is that the effect of the coefficient is neglected for the remainder of the function, meaning the plugin does not work as accurate as it should.

The lines in question:
https://github.com/gazebosim/gz-sim/blob/f6efeefb4ab99284d1a053061235f8c2fa02a5da/src/systems/lift_drag/LiftDrag.cc#L438C3-L440C12

@fredmarkus fredmarkus changed the title Missing coeffficients in LiftDrag Plugin Missing coefficients in LiftDrag Plugin Oct 3, 2023
@fredmarkus fredmarkus mentioned this issue Oct 3, 2023
2 tasks
@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant