Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ScreenToScene function for non-flat planes #464

Open
JShep1 opened this issue Nov 20, 2020 · 0 comments
Open

Improve ScreenToScene function for non-flat planes #464

JShep1 opened this issue Nov 20, 2020 · 0 comments
Labels
bug Something isn't working help wanted We accept pull requests!

Comments

@JShep1
Copy link

JShep1 commented Nov 20, 2020

@chapulina noticed in the PR for the tape measure tool (#456) that the end points for the tape measure are placed in unusual places for a non-flat plane case (like rolling_shapes.sdf). The logic for placing the end points makes use of the ScreenToScene function in Scene3D.cc

I believe there's an underlying assumption that the plane is flat and at the origin(?), although I could be wrong about that. Below is an example that @chapulina recorded.

@JShep1 JShep1 added the bug Something isn't working label Nov 20, 2020
@chapulina chapulina added the help wanted We accept pull requests! label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

2 participants