Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when pressing escape to cancel a model placement #488

Closed
JShep1 opened this issue Dec 15, 2020 · 1 comment · Fixed by #493
Closed

Crash when pressing escape to cancel a model placement #488

JShep1 opened this issue Dec 15, 2020 · 1 comment · Fixed by #493
Assignees
Labels
bug Something isn't working 🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)

Comments

@JShep1
Copy link

JShep1 commented Dec 15, 2020

As found here, if the user continues to select models, most simply just a shape from the top toolbar, and presses escape to cancel the action, a crash will eventually occur.

This is likely due to these calls being made from outside the render thread. If we could have some sort of flag we set when an escape key release is detected and then have the render thread read that flag and perform the deselect and remove operations, this would probably suffice.

@JShep1 JShep1 added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) 🏰 citadel Ignition Citadel labels Dec 15, 2020
@JShep1 JShep1 self-assigned this Dec 15, 2020
@JShep1 JShep1 linked a pull request Dec 16, 2020 that will close this issue
@JShep1
Copy link
Author

JShep1 commented Dec 23, 2020

Fixed in #493

@JShep1 JShep1 closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant