Failing or Flaky test: PeerTracker.PeerTrackerStale

[sloretz]

Environment

• OS Version: osx
• Source or binary build? ignition gazebo 5 homebrew amd64 CI job

Description

https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/3

• Expected behavior: The peer tracker test expected to find no peers
• Actual behavior: One peer was found

Related: A past effort has been made to make this test more reliable in #452 , and only one failure has been seen, so maybe it is just flaky.

Steps to reproduce

1. Run this CI job https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64

Output

test 39
        Start  39: UNIT_PeerTracker_TEST

39: Test command: /Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/build/bin/UNIT_PeerTracker_TEST "--gtest_output=xml:/Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/build/test_results/UNIT_PeerTracker_TEST.xml"
39: Test timeout computed to be: 240
39: Running main() from /Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/ign-gazebo/test/gtest/src/gtest_main.cc
39: [==========] Running 4 tests from 1 test suite.
39: [----------] Global test environment set-up.
39: [----------] 4 tests from PeerTracker
39: [ RUN      ] PeerTracker.PeerTracker
39: [       OK ] PeerTracker.PeerTracker (2463 ms)
39: [ RUN      ] PeerTracker.PeerTrackerStale
39: /Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/ign-gazebo/src/network/PeerTracker_TEST.cc:182: Failure
39: Expected equality of these values:
39:   0u
39:     Which is: 0
39:   tracker1->NumPeers()
39:     Which is: 1
39: �[1;36m[Dbg] [PeerTracker.cc:166] �[0m�[1;36mAttempting to remove peer [�[0m�[1;36me7fc7978-9152-4a86-b840-e4c1d4259569�[0m�[1;36m] from [�[0m�[1;36md7ba1593-bdb1-493a-87a4-98426acc0017�[0m�[1;36m] but it wasn't connected�[0m�[1;36m�[0m
39: [  FAILED  ] PeerTracker.PeerTrackerStale (306 ms)
39: [ RUN      ] PeerTracker.Partitioned
39: [       OK ] PeerTracker.Partitioned (1062 ms)
39: [ RUN      ] PeerTracker.Namespaced
39: [       OK ] PeerTracker.Namespaced (1283 ms)
39: [----------] 4 tests from PeerTracker (5114 ms total)
39: 
39: [----------] Global test environment tear-down
39: [==========] 4 tests from 1 test suite ran. (5114 ms total)
39: [  PASSED  ] 3 tests.
39: [  FAILED  ] 1 test, listed below:
39: [  FAILED  ] PeerTracker.PeerTrackerStale
39: 
39:  1 FAILED TEST
 39/174 Test  #39: UNIT_PeerTracker_TEST ..................................***Failed    5.16 sec

[jacobperron]

Another instance of PeerTracker test failing on macOS, though at a different line: https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/26/

39: [ RUN      ] PeerTracker.PeerTrackerStale
39: /Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo5-homebrew-amd64/ign-gazebo/src/network/PeerTracker_TEST.cc:178: Failure
39: Expected equality of these values:
39:   1
39:   stalePeers
39:     Which is: 2