Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor changes to hydrodynamic flags test #1772

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Oct 28, 2022

🦟 Bug fix

This commit changes the url to use the more recent url. It also removes the scene-broadcaster plugin as we don't need it in the test itself.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@arjo129 arjo129 requested a review from mjcarroll as a code owner October 28, 2022 02:36
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1772 (404f9c7) into ign-gazebo6 (77ea80c) will not change coverage.
The diff coverage is n/a.

❗ Current head 404f9c7 differs from pull request most recent head db8b436. Consider uploading reports for the commit db8b436 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1772   +/-   ##
============================================
  Coverage        64.65%   64.65%           
============================================
  Files              321      321           
  Lines            26275    26275           
============================================
  Hits             16987    16987           
  Misses            9288     9288           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll
Copy link
Contributor

Can I get a sign-off here? Thanks!

This commit changes the url to use the more recent url. It also removes the scene-broadcaster plugin as we don't need it in the test itself.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 force-pushed the arjo/fix/hydro_flag_test branch from 404f9c7 to db8b436 Compare October 28, 2022 12:27
@arjo129
Copy link
Contributor Author

arjo129 commented Oct 28, 2022

Whoops. Apologies, I've signed off now.

@arjo129 arjo129 enabled auto-merge (squash) October 28, 2022 13:17
@arjo129 arjo129 merged commit 132555a into ign-gazebo6 Oct 28, 2022
@arjo129 arjo129 deleted the arjo/fix/hydro_flag_test branch October 28, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants