Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 64 bit signed and unsigned integer type support to UserData #479

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 28, 2021

Signed-off-by: Ian Chen [email protected]

🎉 New feature

Summary

adds support for uint64_t and int64_t types.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033 iche033 requested a review from adlarkin October 28, 2021 00:38
@iche033 iche033 changed the base branch from ign-rendering5 to main October 28, 2021 00:38
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 28, 2021
@iche033 iche033 added 🌱 garden Ignition Garden and removed 🏢 edifice Ignition Edifice labels Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #479 (61ad41a) into main (a8ac08c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files         192      192           
  Lines       19566    19566           
=======================================
  Hits        10467    10467           
  Misses       9099     9099           
Impacted Files Coverage Δ
include/ignition/rendering/Node.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ac08c...61ad41a. Read the comment docs.

@iche033 iche033 merged commit 63264a9 into main Oct 28, 2021
@iche033 iche033 deleted the int64_userdata branch October 28, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants