Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-rendering #669

Merged
merged 2 commits into from
Jul 15, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-rendering #669

merged 2 commits into from
Jul 15, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from iche033 as a code owner July 12, 2022 18:15
@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 8458059 to f57fde6 Compare July 12, 2022 20:55
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 13, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #669 (2ec4bc0) into main (8d7e008) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

❗ Current head 2ec4bc0 differs from pull request most recent head 6332da7. Consider uploading reports for the commit 6332da7 to get more accurate results

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   53.59%   53.59%   -0.01%     
==========================================
  Files         214      214              
  Lines       21423    21420       -3     
==========================================
- Hits        11482    11479       -3     
  Misses       9941     9941
Impacted Files Coverage Δ
include/gz/rendering/Scene.hh 0.00% <ø> (ø)
include/gz/rendering/base/BaseRayQuery.hh 36.84% <ø> (ø)
ogre/src/OgreHeightmap.cc 72.71% <ø> (ø)
ogre/src/OgreMaterialSwitcher.cc 0.00% <0.00%> (ø)
ogre/src/OgreRenderEngine.cc 73.45% <ø> (ø)
ogre/src/OgreSelectionBuffer.cc 0.00% <ø> (ø)
ogre/src/OgreText.cc 0.00% <ø> (ø)
ogre2/src/Ogre2GzHlmsPbsPrivate.hh 100.00% <ø> (ø)
ogre2/src/Ogre2GzHlmsSphericalClipMinDistance.hh 100.00% <ø> (ø)
ogre2/src/Ogre2GzHlmsTerraPrivate.hh 100.00% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7e008...6332da7. Read the comment docs.

methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Move files (#669)
d818916 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Partial source and cmake migrations (#669)
57d263c 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from f57fde6 to 57d263c Compare July 13, 2022 08:26
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Partial source and cmake migrations (#669)
56e162f 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 57d263c to 56e162f Compare July 13, 2022 08:46
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 56e162f to 6332da7 Compare July 13, 2022 20:27
@methylDragon methylDragon merged commit b0c83c3 into main Jul 15, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 15, 2022 00:35
methylDragon added a commit that referenced this pull request Jul 15, 2022
@methylDragon
Move files (#669)
3c657a7 
Signed-off-by: methylDragon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina