Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy GpuRay camera on exit #698

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Destroy GpuRay camera on exit #698

merged 2 commits into from
Aug 4, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 3, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Destroy camera on exit in Ogre2GpuRay class, which is also done in gz-rendering6 here. This also ensures the Destroy function can be called multiple times.

This should fix the gpu lidar test in gz-sensors.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 3, 2022
@iche033 iche033 requested review from mjcarroll and chapulina August 3, 2022 18:45
@chapulina chapulina added the bug Something isn't working label Aug 3, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 , I just have a couple of questions that are not blockers.

ogre2/src/Ogre2GpuRays.cc Outdated Show resolved Hide resolved
ogre2/src/Ogre2GpuRays.cc Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #698 (0a4daf3) into main (37441a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0a4daf3 differs from pull request most recent head 734dfed. Consider uploading reports for the commit 734dfed to get more accurate results

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   74.14%   74.16%   +0.01%     
==========================================
  Files         159      159              
  Lines       14365    14370       +5     
==========================================
+ Hits        10651    10657       +6     
+ Misses       3714     3713       -1     
Impacted Files Coverage Δ
ogre2/src/Ogre2GpuRays.cc 91.43% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ian Chen <[email protected]>
@chapulina chapulina merged commit f5101c4 into main Aug 4, 2022
@chapulina chapulina deleted the gpu_ray_destroy_camera branch August 4, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants