Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use SuppressWarning from ign-utils #193

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll [email protected]

@mjcarroll mjcarroll requested a review from iche033 as a code owner February 8, 2022 18:50
@mjcarroll mjcarroll self-assigned this Feb 8, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #193 (da19a62) into main (0365e3e) will not change coverage.
The diff coverage is n/a.

❗ Current head da19a62 differs from pull request most recent head b8d4590. Consider uploading reports for the commit b8d4590 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files          30       30           
  Lines        3092     3092           
=======================================
  Hits         2198     2198           
  Misses        894      894           
Impacted Files Coverage Δ
include/ignition/sensors/ForceTorqueSensor.hh 100.00% <ø> (ø)
include/ignition/sensors/Manager.hh 81.81% <ø> (ø)
include/ignition/sensors/NavSatSensor.hh 100.00% <ø> (ø)
include/ignition/sensors/SensorFactory.hh 58.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83855aa...b8d4590. Read the comment docs.

@mjcarroll
Copy link
Contributor Author

Windows failure is from new warnings from protobuf, not related to this.

@mjcarroll mjcarroll merged commit b1f78a5 into main Feb 8, 2022
@mjcarroll mjcarroll deleted the use_ign_utils_suppress branch February 8, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants