Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement snap-to feature for //pose/@rotation_type conversion #646

Closed
EricCousineau-TRI opened this issue Jul 29, 2021 · 7 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@EricCousineau-TRI
Copy link
Collaborator

Desired behavior

Per proposal http://sdformat.org/tutorials?tut=better_pose_proposal&cat=pose_semantics_docs&, should allow conversion among rotation types (e.g. from `rpy_degrees

Alternatives considered

See proposal

Implementation suggestion

See proposal

Additional context

See proposal

@EricCousineau-TRI EricCousineau-TRI added the enhancement New feature or request label Jul 29, 2021
@FirefoxMetzger
Copy link
Contributor

@EricCousineau-TRI Is it possible to comment on proposals somewhere? Based on the motivation, I was wondering if the following alternative has been considered:

<pose>
  <value degrees="True">0 0 0 90 45 0</value>
</pose>

Making it degrees=False by default would make the entire thing backward compatible with 1.8.

@chapulina
Copy link
Contributor

@FirefoxMetzger , those are hosted at sdf_tutorials, i.e. gazebosim/sdf_tutorials#37

@FirefoxMetzger
Copy link
Contributor

@chapulina Thanks :) Would I create an issue there to comment on a proposal, or what is the preferred approach?

@chapulina
Copy link
Contributor

Good question, I'd say it's best to open an issue here at sdformat for greater visibility. If you have specific suggestions, you could open a PR against the proposal.

@azeey
Copy link
Collaborator

azeey commented Jul 30, 2021

FWIW, the option we're currently working in #589 is <pose rotation_type="rpy_radians/rpy_degrees/q_wxyz">. By default @rotation_type=rpy_radians so it would be backward compatible.

@FirefoxMetzger
Copy link
Contributor

Thanks for pointing that out @azeey . I skimmed the PR and it does look like the better choice than <value degrees="True/False">.

@EricCousineau-TRI
Copy link
Collaborator Author

Closing given merge of #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants