Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error decoding/generating precomp file in latest branch #186

Closed
gballet opened this issue Mar 20, 2023 · 2 comments
Closed

Error decoding/generating precomp file in latest branch #186

gballet opened this issue Mar 20, 2023 · 2 comments

Comments

@gballet
Copy link
Owner

gballet commented Mar 20, 2023

This happens in cache-point-in-access-witness after merging #184.

Using a precomp file from master, it will cause the following stack trace. The same stack trace will happen when starting with a missing file.

--- FAIL: TestReproduceTree (0.07s)
panic: runtime error: makeslice: len out of range [recovered]
	panic: runtime error: makeslice: len out of range

goroutine 76409 [running]:
testing.tRunner.func1.2({0x6616a0, 0x708f40})
	/usr/local/go/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1529 +0x39f
panic({0x6616a0, 0x708f40})
	/usr/local/go/src/runtime/panic.go:884 +0x213
github.com/crate-crypto/go-ipa/banderwagon.(*LagrangeTablePoints).Deserialize(0xc0002f2060, {0x7096e0, 0xc000702000})
	/home/gballet/go/pkg/mod/github.com/crate-crypto/[email protected]/banderwagon/precomp_multiexp.go:258 +0x19d
github.com/crate-crypto/go-ipa/banderwagon.DeserializePrecomputedLagrange({0x7096e0, 0xc000702000})
	/home/gballet/go/pkg/mod/github.com/crate-crypto/[email protected]/banderwagon/precomp_multiexp.go:152 +0x1c5
github.com/crate-crypto/go-ipa/ipa.DeserializeSRSPrecomp({0xc004e70000, 0x7f84018, 0x7f84019})
	/home/gballet/go/pkg/mod/github.com/crate-crypto/[email protected]/ipa/srs_precomp.go:73 +0x1a6
github.com/gballet/go-verkle.GetConfig()
	/home/gballet/go/pkg/mod/github.com/gballet/[email protected]/config_ipa.go:61 +0x95
github.com/gballet/go-verkle.NewLeafNode({0xc0003cce00, 0x1f?, 0x40}, {0xc000647800, 0x100, 0x100})
	/home/gballet/go/pkg/mod/github.com/gballet/[email protected]/tree.go:218 +0x1dc
github.com/gballet/go-verkle.(*InternalNode).InsertStem(0xc0006af800, {0xc0003cce00, 0x1f, 0x40}, {0xc000647800, 0x100, 0x100}, 0x0)
	/home/gballet/go/pkg/mod/github.com/gballet/[email protected]/tree.go:291 +0x11e
github.com/gballet/go-verkle.(*InternalNode).Insert(0x6acc84?, {0xc0003cce00, 0x20, 0x40}, {0xc0003cd1c0, 0x20, 0x40}, 0x41c591?)
	/home/gballet/go/pkg/mod/github.com/gballet/[email protected]/tree.go:282 +0xdc
github.com/ethereum/go-ethereum/trie.TestReproduceTree(0xc0003c4820)
	/home/gballet/src/go-ethereum/trie/verkle_test.go:71 +0xd4b
testing.tRunner(0xc0003c4820, 0x6c5ac0)
	/usr/local/go/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1629 +0x3ea
FAIL	github.com/ethereum/go-ethereum/trie	46.549s
FAIL

Command to reproduce:

$ go test ./trie
@jsign
Copy link
Collaborator

jsign commented Mar 20, 2023

This test doesn't fail locally (with or without a precomp file).

Looking in our CI, I noticed we're still downloading old precomp there.

Created #187 to update and we can see if now CI is happy.

@gballet
Copy link
Owner Author

gballet commented Mar 20, 2023

Solved, thanks @jsign

@gballet gballet closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants