When Creating Http Client Allow SocketTimeout & ConnectionTimeout & ConnectionRequestTimeout To Be Set Externally

[bhreinb]

At the moment the default timeout values within the following source file

https://github.com/poynt/postman-runner/blob/master/src/main/java/co/poynt/postman/PostmanRequestRunner.java are

SocketTimeout -> 60000
ConnectTimeout -> 5000
ConnectionRequestTimeout -> 60000

in some circumstances that timeout isn't sufficient for some web services we test against so it would be great if their was a means to override these default values.

[vchau]

If you are programmatically calling, would accepting a http client provider be sufficient?

[bhreinb]

Hi @vchau

I'm slightly confused as to what you mean here. The http client gets created for me through method

public boolean run(PostmanItem item, PostmanRunResult runResult) {

from here

https://github.com/poynt/postman-runner/blob/master/src/main/java/co/poynt/postman/PostmanRequestRunner.java#L76

which in turn invokes

protected CloseableHttpClient createHttpClient() {

so the outer method run doesn't return a http client. So I'm assuming to accept a http client some refactor of the existing code would need to be done? If that was done then I assume the http client would be created without the default request config, which likely would be done by a consumer of the library right (me in this case)?

Another very quick fix potentially could be

public static int SOCKET_TIMEOUT = 60000;
public static int CONNECT_TIMEOUT = 5000;
public static int CONNECTION_REQUEST_TIMEOUT = 5000;

or nicer again through the use of getters and setters.

[vchau]

Sorry, I meant we can change the PostmanRequestRunner constructor to also take an optional http client provider. That way, you can pass in your own http client. For example:

public interface HttpClientProvider {

	CloseableHttpClient getHttpClient();

}

public PostmanRequestRunner(PostmanVariables var, boolean haltOnError, HttpClientProvider provider) {
		...
}

[bhreinb]

Hi @vchau

Yeah this could work. If you don't mind please change the constructor to add a Http client please.