Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Validate input for update notification settings #771

Merged
merged 6 commits into from
Jun 10, 2018
Merged

Validate input for update notification settings #771

merged 6 commits into from
Jun 10, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 8, 2018

Description:

Input for NotificationSettingsApi is not validated. Check for course and user missing.

Improvements

  • Validate input for notification settings api

@kesselb kesselb added bug This Issue describes a unwanted behavior api All Backend related Issues labels Jun 8, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2493

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 65.931%
Totals Coverage Status
Change from base Build 2474: 0.3%
Covered Lines: 1152
Relevant Lines: 1676
💛 - Coveralls

@PatrickSkowronek PatrickSkowronek merged commit e68e2d1 into develop Jun 10, 2018
@PatrickSkowronek PatrickSkowronek deleted the bugfix/validate-input-notification-settings branch June 10, 2018 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PatrickSkowronek PatrickSkowronek PatrickSkowronek approved these changes

Assignees
No one assigned
Labels
api All Backend related Issues bug This Issue describes a unwanted behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @coveralls @PatrickSkowronek