Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeodesicArea method names differ from Area and ChamberlainDuquetteArea #1292

Open
JosiahParry opened this issue Dec 28, 2024 · 2 comments
Open

Comments

@JosiahParry
Copy link
Contributor

Taken from geoarrow/geoarrow-rs#969

The Area and ChamberlainDuquetteArea traits have methods with names signed_area() and unsigned_area() whereas the GeodesicArea trait has name area_signed() and area_unsigned().

It would be nice to have these renamed to be in line with the others.

@amir002001
Copy link

@frewsxcv can I do this as a first issue please?

@michaelkirk
Copy link
Member

Sure @amir002001.

Please rename the methods in GeodesicArea to match the names used in the other two traits.

Leave the old methods with the existing spellings for a while, but add a deprecated attribute, so that we don't break any builds, and legacy users can find the new spelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants