-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Add complete set of integration tests #714
Comments
I've ran into an issue a couple times where ExtData.rc was missing an update in HEMCO_Config.rc. If we're putting together a wishlist, I would add something to check that ExtData.rc and HEMCO_Config.rc are in agreement. Note: I haven't ran into this with official releases, but often I work with developement code and I've ran into it there. |
Looks good. I think once we have zero diffs across single and multi runs we could have a regular test for that too. We aren't there yet though. @LiamBindle, regarding your request, we've put that on hold pending the update of ExtData.rc and HEMCO_Config.rc to yaml. However, if we find an eager student to put together a script to check the config files as they are now then we should definitely encourage that. |
I just expanded the list to include GCHP RRTMG. |
I've re-enabled the nested-grid integration tests. This was made possible by creating new sample boundary condition files as described in #811. |
Also note: integration tests now use default run directory names in PR #1565 |
I've added a GCHP RRTMG integration test as part of #1565. |
@lizziel @msulprizio: Do we still need "DIfference tests for zero-diff updates?" We now have that implmented via the 1-hr cloud benchmarks. |
I added a dry run integration test to the list. |
The GEOS-Chem integration tests have in general been working well and have allowed us to catch and fix several issues in both GCClassic and GCHP before releasing a new version.
However, some recent "edge cases" (cf geoschem/HEMCO#82, geoschem/HEMCO#84) were not caught by the integration tests and thus required subsequent bug fix commits.
The following additional integration tests would be very useful:
Restarts/
rundir folder for each test (see Run directory updates for integration tests #1794)HEMCO_diagnostics*nc
are saved to theOutputDir/
rundir folder for each test (see Run directory updates for integration tests #1794)@lizziel, @msulprizio, @yidant: feel free to add to this list
The text was updated successfully, but these errors were encountered: