From 074a5c8d928a754392da9f310a1e61986d93e270 Mon Sep 17 00:00:00 2001 From: kappu Date: Mon, 23 Jan 2017 11:32:18 +0100 Subject: [PATCH] Fixes on Lore's review and fixed ordering bugs --- web/client/components/TOC/DefaultLayerOrGroup.jsx | 2 +- web/client/reducers/layers.js | 6 +++--- web/client/utils/LayersUtils.js | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/web/client/components/TOC/DefaultLayerOrGroup.jsx b/web/client/components/TOC/DefaultLayerOrGroup.jsx index da42b46176..0dce2b67a8 100644 --- a/web/client/components/TOC/DefaultLayerOrGroup.jsx +++ b/web/client/components/TOC/DefaultLayerOrGroup.jsx @@ -1,5 +1,5 @@ /** - * Copyright 2016, GeoSolutions Sas. + * Copyright 2017, GeoSolutions Sas. * All rights reserved. * * This source code is licensed under the BSD-style license found in the diff --git a/web/client/reducers/layers.js b/web/client/reducers/layers.js index a51455ca00..6a2fcb9e88 100644 --- a/web/client/reducers/layers.js +++ b/web/client/reducers/layers.js @@ -44,17 +44,17 @@ const deepRemove = (nodes, findValue) => { } return nodes; }; -const getNode = (nodes, name) => { +const getNode = (nodes, id) => { if (nodes && isArray(nodes)) { return nodes.reduce((previous, node) => { if (previous) { return previous; } - if (node && (node.name === name || node.id === name)) { + if (node && (node.name === id || node.id === id)) { return node; } if (node && node.nodes && node.nodes.length > 0) { - return getNode(node.nodes, name); + return getNode(node.nodes, id); } return previous; }, null); diff --git a/web/client/utils/LayersUtils.js b/web/client/utils/LayersUtils.js index 0699d7c29b..cb50ee651e 100644 --- a/web/client/utils/LayersUtils.js +++ b/web/client/utils/LayersUtils.js @@ -19,15 +19,15 @@ const getLayersId = (groupId, allLayers) => { return allLayers.filter((layer) => (layer.group || 'Default') === groupId).map((layer) => layer.id).reverse(); }; const initialReorderLayers = (groups, allLayers) => { - return groups.slice(0).reduce((previous, group) => { + return groups.slice(0).reverse().reduce((previous, group) => { return previous.concat( - group.nodes.reduce((layers, node) => { + group.nodes.slice(0).reverse().reduce((layers, node) => { if (isObject(node)) { - return layers.concat(initialReorderLayers([node], allLayers).reverse()); + return layers.concat(initialReorderLayers([node], allLayers)); } return layers.concat(getLayer(node, allLayers)); }, []) - ).reverse(); + ); }, []); }; const reorderLayers = (groups, allLayers) => {