From bb3c0f530d53e5a0ed98a0419df5fba1cdb34b54 Mon Sep 17 00:00:00 2001 From: Lorenzo Natali Date: Wed, 15 Feb 2017 12:12:54 +0100 Subject: [PATCH 1/3] Fix #1453. Improved style in user manager Now support long group names and long groups lists. --- web/client/components/manager/users/UserCard.jsx | 16 ++++++++++++++-- .../manager/users/style/userdialog.css | 9 +++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/web/client/components/manager/users/UserCard.jsx b/web/client/components/manager/users/UserCard.jsx index ceb4c05862..1acc77bd1a 100644 --- a/web/client/components/manager/users/UserCard.jsx +++ b/web/client/components/manager/users/UserCard.jsx @@ -34,7 +34,9 @@ const UserCard = React.createClass({ backgroundPosition: "center", backgroundRepeat: "repeat-x" }, - innerItemStyle: {"float": "left", margin: "10px"} + innerItemStyle: {"float": "left", + margin: "10px" + } }; }, renderStatus() { @@ -47,7 +49,17 @@ const UserCard = React.createClass({ }, renderGroups() { return (
- {this.props.user && this.props.user.groups ? this.props.user.groups.map((group)=> (
{group.groupName}
)) : null} +
{this.props.user && this.props.user.groups ? this.props.user.groups.map((group) => (
{group.groupName}
)) : null}
+
); }, renderRole() { diff --git a/web/client/components/manager/users/style/userdialog.css b/web/client/components/manager/users/style/userdialog.css index a2fbf20a3e..7901a112c0 100644 --- a/web/client/components/manager/users/style/userdialog.css +++ b/web/client/components/manager/users/style/userdialog.css @@ -22,3 +22,12 @@ text-overflow: ellipsis; overflow: hidden; } +.user-edit-dialog .Select--multi .Select-value-label{ + max-width: 180px; + overflow: hidden; + text-overflow: ellipsis; +} +.user-edit-dialog .Select-multi-value-wrapper { + max-height: 300px; + overflow: auto; +} From 2a6f9f6b614fc249f91501c2bd17f566aaf04079 Mon Sep 17 00:00:00 2001 From: Lorenzo Natali Date: Wed, 15 Feb 2017 15:06:42 +0100 Subject: [PATCH 2/3] fixed group selecttor with only one group --- web/client/components/manager/users/style/userdialog.css | 1 + 1 file changed, 1 insertion(+) diff --git a/web/client/components/manager/users/style/userdialog.css b/web/client/components/manager/users/style/userdialog.css index 7901a112c0..152d2c6295 100644 --- a/web/client/components/manager/users/style/userdialog.css +++ b/web/client/components/manager/users/style/userdialog.css @@ -30,4 +30,5 @@ .user-edit-dialog .Select-multi-value-wrapper { max-height: 300px; overflow: auto; + min-height: 36px; } From 7dcf6c4359cfbb5cb6aa69b2338d7db2091ca5a3 Mon Sep 17 00:00:00 2001 From: Lorenzo Natali Date: Wed, 15 Feb 2017 16:27:28 +0100 Subject: [PATCH 3/3] refactored using flex-box --- .../components/manager/users/UserCard.jsx | 25 +++++++------------ .../manager/users/style/usercard.css | 24 ++++++++++++++++++ 2 files changed, 33 insertions(+), 16 deletions(-) diff --git a/web/client/components/manager/users/UserCard.jsx b/web/client/components/manager/users/UserCard.jsx index 1acc77bd1a..51cb62fbb3 100644 --- a/web/client/components/manager/users/UserCard.jsx +++ b/web/client/components/manager/users/UserCard.jsx @@ -48,27 +48,18 @@ const UserCard = React.createClass({ ); }, renderGroups() { - return (
-
{this.props.user && this.props.user.groups ? this.props.user.groups.map((group) => (
{group.groupName}
)) : null}
+ return (
+
{this.props.user && this.props.user.groups ? this.props.user.groups.map((group) => (
{group.groupName}
)) : null}
); }, renderRole() { - return (
+ return (
{this.props.user.role}
); }, renderAvatar() { - return (
); }, @@ -77,9 +68,11 @@ const UserCard = React.createClass({ - {this.renderAvatar()} - {this.renderRole()} - {this.renderGroups()} +
+ {this.renderAvatar()} + {this.renderRole()} + {this.renderGroups()} +
{this.renderStatus()}
); diff --git a/web/client/components/manager/users/style/usercard.css b/web/client/components/manager/users/style/usercard.css index 0fa06a8a7f..82013ee6d0 100644 --- a/web/client/components/manager/users/style/usercard.css +++ b/web/client/components/manager/users/style/usercard.css @@ -12,7 +12,31 @@ .user-thumb .gridcard-tools,.group-thumb .gridcard-tools { right: 0 } +.user-data-container { + display: flex; + width: 100%; +} +.user-thumb .role-containter{ + width: 50px; +} +.user-thumb .avatar-containter{ + width: 50px; +} +.user-thumb .groups-container { + white-space: nowrap; + overflow: hidden; +} +.user-thumb .groups-container .groups-list{ + width: 100%; + max-height: 100px; + overflow-y: auto; + overflow-x: hidden; +} +.user-thumb .groups-container .groups-list .group-item { + overflow-x: hidden; + text-overflow: ellipsis; +} .group-thumb .group-thumb-description { /* ellipsis for description */ margin: 10px;