New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use hardcoded oauth tokens #3

Open

cezio opened this issue Jun 12, 2018 · 0 comments

cezio commented Jun 12, 2018 •

edited

Loading

At the moment oauth tokens for GS app are hardcoded in:

https://github.com/geosolutions-it/geonode-generic/blob/master/tasks.py#L205-L207
https://github.com/geosolutions-it/geonode-project/blob/master/tasks.py#L188-L191
https://github.com/GeoNode/geoserver-geonode-ext/blob/master/geoserver/data/geonode_v213x/security/filter/geonode-oauth2/config.xml#L8-L9

We should parametrize them and generate tokens (especially secret) per deployment.

Also, instead of having fixture hardcoded in tasks.py, we can parse fixture from repo and change it in tasks.py to avoid duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment