Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments passed in wrong order to harvest_resources #472

Closed
giohappy opened this issue Nov 12, 2021 · 3 comments
Closed

Arguments passed in wrong order to harvest_resources #472

giohappy opened this issue Nov 12, 2021 · 3 comments
Assignees
Labels
bug Something isn't working GeoNode This issue requires work on GeoNode Harvester

Comments

@giohappy
Copy link
Contributor

@ricardogsilva I was testing the PDN harvesting locally and I noticed the following problem:

  1. I select a single harvestable resource to be harvested
    2 I run the harvesting
  2. harvester.initiate_perform_harvesting(harvestable_resource_ids) is called with the list containing the single resource id
  3. down the path the harvester.tasks.harvest_resources(harvestable_resource_id, harvesting_session_id) is called but the received arguments are filpped and models.AsynchronousHarvestingSession.objects.get(pk=harvesting_session_id) fails.

Indeed the task signature of the method has the arguments flipped.

Are we sure tests are passing?

@giohappy giohappy added GeoNode This issue requires work on GeoNode bug Something isn't working Harvester labels Nov 12, 2021
@ricardogsilva
Copy link
Contributor

I confirm this is a bug - Manually dispatching individual harvestable resources is something I forgot to update when doing one of the more recent refactorings

@ricardogsilva
Copy link
Contributor

Referenced upstream at GeoNode/geonode#8377

@ricardogsilva
Copy link
Contributor

PR submitted at GeoNode/geonode#8378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GeoNode This issue requires work on GeoNode Harvester
Projects
None yet
Development

No branches or pull requests

2 participants