Performance and memory leaks

[sprzenus]

After dismissing the view my custom subclass of ScanBaseViewController is leaking. Moreover, after dismissing the view before it loads makes CPU usage be still on ~30% on a real device when I dismiss the view. I think removing memory leaks of the ScanBaseViewController would do the thing

[kingst]

I think I can see what's going on with the memory leak, I'll take a look at this today.

[kingst]

I can't seem to reproduce the 30% issue and when I run the library through the memory checker it looks like I'm only leaking two small objects (see screen shot below). Can you help me reproduce what you're seeing?

[sprzenus]

We push our controller on a navigation controller's stack and we leaking the view controller just after poping to the previous view controller. The issue with CPU usage happens when I exit the view before the white view disappears and the camera view appears

[kingst]

Before I dig in deeper about these issues, why are you subclassing ScanBaseViewController? We have a number of UI customizations that we make available for our ScanViewController, although we don't have documentation for them yet you can see them in use in the example app here.

Are these UI customizations enough for what you're looking to do? If not, what's missing?

[sprzenus]

Here you are: #74
We work on the same project

[kingst]

I added everything that he asked for in that issue -- I highly suggest trying to go that route instead of subclassing ScanBaseViewController. We subclass it ourselves for our anti-fraud products, but it's messy and not really designed for general use.

[kingst]

closing this issue, please let us know if this is still a problem