[v4] Translate function doesn't work with field values anymore

[tobimori]

Description

I use the following code to get a translated label for a value from a site field, which worked fine in Kirby 3:

https://github.com/tobimori/kirby-seo/blob/main/blueprints/fields/og-group.yml#L35

    placeholder: "{{ t('default-select') }} {{ t(site.twitterCardType) }}"

Yet, with Kirby 4, I'm missing the output for the translated card type:

When removing the translation helpers, I can see that the data can be accessed correctly.

It works correctly when appending .value to site.twitterCardType:

    placeholder: "{{ t('default-select') }} {{ t(site.twitterCardType.value) }}"

To reproduce

Install my SEO plugin with Kirby 4.0, or test using the code snippets above.

Your setup

Kirby Version 4.0-alpha.1

[distantnative]

@tobimori if you have any quick way to double check that this isn't already broken in3.9.4, would be helpful. If not, don't worry - just won't get myself on a laptop that soon to do myself and trying to debug via GitHub on my phone 🤣

[afbora]

@distantnative I've tested on 3.9.4 and works great.

[tobimori]

Yep, works on the sites where this plugin is running with v3.9.4.

[distantnative]

Does ist work for you when removing declare(strict_types = 1); from src/Query/Query.php?

[distantnative]

That would be my current hunch - that previously the Field object implicitly got casted to its value and due to this line Kirby now would want you to add .value (which would not be great, we would look into easing this - just trying to find the reason for the bug first).

[afbora]

I can't see declare(strict_types = 1); in any files.

[afbora]

Also not working with .value (but works in 3.9.x)

[distantnative]

@afbora https://github.com/getkirby/kirby/blob/v4/main/src/Query/Query.php#L3 - and @tobimori described that it's working with .value

[afbora]

@distantnative Sorry, I tested on v4/develop and it hasn't that line.

[afbora]

But v4/main still doesn't work for me. With removing strict_types and .value

placeholder: "{{ t('foo') }} {{ t(model.text.value) }}"

[tobimori]

It doesn't seem to fix it. .value still works.

[distantnative]

Observation: works on v4/develop but not v4/main

[distantnative]

Works when removing strict mode from src/Query/Segment.php