Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offline basemaps available from general settings #1610

Closed
lognaturel opened this issue Nov 8, 2017 · 4 comments
Closed

Make offline basemaps available from general settings #1610

lognaturel opened this issue Nov 8, 2017 · 4 comments
Labels
enhancement help wanted Issues that are well-specified and don't require too much context.

Comments

@lognaturel
Copy link
Member

When Google Maps SDK is selected as the Mapping SDK, if there are offline basemaps available, after the built in basemaps (Streets, Satellite, etc), display a "Offline Layers" heading and a list of offline layers. This will allow enumerators to set the offline layer once for use across multiple forms/instances. Offline map tiles are described in links from getodk/docs#3

The dialog will need to scroll to fit all. This should be resilient to things like manual deletion of the selected offline base map. In that case, the selected basemap should default back to Streets.

@lognaturel lognaturel added help wanted Issues that are well-specified and don't require too much context. enhancement labels Nov 8, 2017
@grzesiek2010
Copy link
Member

So it will look like eg:

Online Layers

  • Streets

  • Satelite

  • Terrain

  • Hybrid

Offline Layers

  • layer1

  • layer2

  • layer3

It might be confusing because it would be two separate lists but only one selected option allowed.

So maybe one list like now but with tags: Online/Offline?
something like that:

Basemaps

  • Streets (Online)

  • Satelite (Online)

  • Terrain (Online)

  • Hybrid (Online)

  • layer1 (Offline)

  • layer2 (Offline)

  • layer3 (Offline)

what do you think @lognaturel ?

@lognaturel
Copy link
Member Author

I like it, @grzesiek2010. I think we can leave the standard ones as they are now -- Streets, Satellite, etc without any parentheses -- and only add the parenthetical for offline layers. Do you think (offline) is the right text? We could also do (custom) or (custom, offline).

@grzesiek2010
Copy link
Member

@opendatakit-bot claim

@getodk-bot
Copy link
Member

getodk-bot commented Dec 29, 2017

Hello @grzesiek2010, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Issues that are well-specified and don't require too much context.
Projects
None yet
Development

No branches or pull requests

3 participants