-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor list views using Adapter Pattern #2127
Comments
@huangyz0918 I refactored our HierarchyView to show what I meant it's here #2128 |
When it comes to MediaLayout I'm not sure if it should be an adapter (since we don't use a list there) but the layout should be created using an xml file at least to avoid all those if statements. |
@grzesiek2010 Yes it really needs a refactor but I'm too busy recently (I have to prepare my English exam), so let's see if anyone can take a look and improve this. |
Ok, I see no problem. I appreciate your help! |
@opendatakit-bot claim |
ERROR: This active issue has no assignee. |
4 similar comments
ERROR: This active issue has no assignee. |
ERROR: This active issue has no assignee. |
ERROR: This active issue has no assignee. |
ERROR: This active issue has no assignee. |
@opendatakit-bot claim |
Problem description
As @grzesiek2010 said in #2099 , It's better to refactor lists using Adapter Pattern. So thanks : )
It can:
if-else
statements.Which list may need this refactor?
MediaLayout.java
-->setAVT
method or others.HierarchyElementView.java
or others. (need discussion whether it needs a refactor or not)Expected behavior
Code can be easier to read and modify with Adapter Pattern.
@opendatakit-bot label "refactor"
@grzesiek2010 I think PR #2123 and PR #2099 are hot fix pull requests focus on specific issues, if we need to refactor related lists, we can work on this issue after hot fixes were merged.
The text was updated successfully, but these errors were encountered: