Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe how best to support light and dark themes when adding UI components #2165

Closed
lognaturel opened this issue May 1, 2018 · 3 comments

Comments

@lognaturel
Copy link
Member

lognaturel commented May 1, 2018

#2061 adds support for a dark theme. 🎉

As new UI components are added, they need to use colorControlNormal, primaryTextColor, etc to make sure the look changes based on the the theme. Advice on how best to do that should be added to https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md. This should also be linked to from the pull request template.

@shobhitagarwal1612, as the feature developer, I think you are best positioned to take a first pass when you get a chance! 😊

@shobhitagarwal1612
Copy link
Contributor

Thanks @lognaturel
Will definitely do it soon 😄

@jd-alexander
Copy link
Contributor

@shobhitagarwal1612 How does the buttons on the MainScreenActivity get their colour? I want to use that setup for a component but at first glance I haven't been able to figure it out.

@shobhitagarwal1612
Copy link
Contributor

@jd-alexander the buttons are coloured implicitly. We don't need to mention the colour, it automatically picks from the current theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants